bug(Table): not restore scrollbar after close drawer edit form#5780
Merged
bug(Table): not restore scrollbar after close drawer edit form#5780
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request includes changes to the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the animation delay into a constant for better maintainability.
- The addition of
_renderandShouldRenderseem a bit heavy-handed; is there a simpler way to control rendering?
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5780 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 658 658
Lines 30033 30056 +23
Branches 4243 4243
=========================================
+ Hits 30033 30056 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5779
Summary By Copilot
This pull request includes various changes to the
Drawercomponent in theBootstrapBlazorlibrary to improve its functionality and code quality. The most important changes include updating the version, refactoring the backdrop rendering, adding a render control flag, and modifying the JavaScript and SCSS files for better animation handling and styling.Version Update:
9.5.3-beta01in theBootstrapBlazor.csprojfile.Refactoring and Enhancements:
Drawer.razorto use theRenderBackdropmethod for rendering the backdrop._renderflag andShouldRendermethod to control rendering inDrawer.razor.cs.RenderBackdropmethod and updatedOnContainerClickto manage rendering state inDrawer.razor.cs. [1] [2]JavaScript and SCSS Modifications:
Drawer.razor.jsto handle animation frames and backdrop visibility. [1] [2] [3] [4]Drawercomponent to improve styling and support reduced motion preferences. [1] [2] [3] [4] [5]Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Fix scrollbar restoration and improve drawer component behavior after closing the edit form
Bug Fixes:
Enhancements:
Tests: